Add missing LSP Handlers #2463
Merged
Add missing LSP Handlers #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
approved these changes
Oct 26, 2022
| ExcludeDefinition = false | ||
| }; | ||
|
|
||
| var omnisharpResponse = await _findUsagesHandler.Handle(omnisharpRequest); |
There was a problem hiding this comment.
interesting - findusages returns a quick fix response that actually contains document highlights? Some strange naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered as part of the work to move the C# extension over to using the O# LSP.
Other missing handlers:
InlayHintsHandler - Required csharp-language-server-protocol to update with the 3.17 spec. I believe this is currently in a feature branch.